Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix where on polymorphic association with empty array #41063

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Fix where on polymorphic association with empty array #41063

merged 1 commit into from
Jan 9, 2021

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Jan 9, 2021

Fix for #40951 (comment).

@kamipo kamipo merged commit 441c5cd into rails:master Jan 9, 2021
@kamipo kamipo deleted the fix_where_with_polymorphic_association_2 branch January 9, 2021 04:57
kamipo added a commit that referenced this pull request Jan 9, 2021
@kamipo
Merge pull request #41063 from kamipo/fix_where_with_polymorphic_asso…
90339be 
…ciation_2

Fix `where` on polymorphic association with empty array
@dbussink dbussink mentioned this pull request Jan 13, 2021
Closed
@jonathanhefner jonathanhefner linked an issue Jan 13, 2021 that may be closed by this pull request
"Unsupported argument type: NilClass. Construct an Arel node instead." when using where(polymorphic_association: []) #41105
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
1 participant
@kamipo